Merge pull request #90 from tdakkota/fix-gomap

Fix gomap datarace
philippgille · Feb 10, 2020 · d421395 · d421395
2 parents 1f76ccc + 4e79f38
commit d421395
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/gomap/gomap.go b/gomap/gomap.go
@@ -65,6 +65,8 @@ func (s Store) Delete(k string) error {
 		return err
 	}
 
+	s.lock.Lock()
+	defer s.lock.Unlock()
 	delete(s.m, k)
 	return nil
 }

diff --git a/test/test.go b/test/test.go
@@ -353,4 +353,14 @@ func InteractWithStore(store gokv.Store, key string, t *testing.T, waitGroup *sy
 	if err != nil {
 		t.Error(err)
 	}
+	// Delete
+	err = store.Delete(key)
+	if err != nil {
+		t.Error(err)
+	}
+	// Read
+	_, err = store.Get(key, new(Foo))
+	if err != nil {
+		t.Error(err)
+	}
 }