Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for BadgerDB #16

Closed
philippgille opened this issue Nov 5, 2018 · 0 comments
Closed

Add implementation for BadgerDB #16

philippgille opened this issue Nov 5, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@philippgille
Copy link
Owner

As listed in the README, BadgerDB should be supported by gokv.

It's seen as an alternative to bbolt, but the underlying DB algorithms (B+ vs LSM trees) suggest that bbolt is generally faster for reads and BadgerDB is generally faster for writes.
@philippgille philippgille added the enhancement New feature or request label Nov 5, 2018
@philippgille philippgille mentioned this issue Nov 6, 2018
Merged
philippgille added a commit that referenced this issue Nov 7, 2018
@philippgille
Fix BadgerDB tests only test the bbolt implementation
99f147c 
- When working on the BadgerDB implementation (#16) I copied the bbolt implementation and tests and must have forgotten to adapt the tests
philippgille added a commit that referenced this issue Nov 7, 2018
@philippgille
Fix BadgerDB impl returns error when a key is not found
1790db3 
- Fix after noticing the error after the test fix (see previous commit)

Related to #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philippgille