Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proto package to protobuf #171

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Jan 21, 2024

While both terms are commonly used to refer to protocol buffers, "protobuf" might be a bit more formal and recognizable, for example because the official website for protocol buffers is https://protobuf.dev/, the main repo is https://github.com/protocolbuffers/protobuf, and the Go library is https://github.com/protocolbuffers/protobuf-go, where they use the tag protobufs but not proto.

While in their Go library the main package that's used when working with protocol buffers is still the proto one at https://pkg.go.dev/google.golang.org/protobuf/proto, I think "protobuf" is still the more recognizable one when referring to the encoding as a whole.

@philippgille philippgille force-pushed the rename-proto-package-to-protobuf branch from 4eda313 to 0c327bb Compare January 21, 2024 16:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (918b014) 63.64% compared to head (d68f94b) 63.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files          25       25           
  Lines        2107     2107           
=======================================
  Hits         1341     1341           
  Misses        651      651           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille force-pushed the rename-proto-package-to-protobuf branch from 0c327bb to d68f94b Compare January 21, 2024 18:18
@philippgille philippgille marked this pull request as ready for review January 21, 2024 19:13
@philippgille philippgille merged commit 6bcd482 into master Jan 21, 2024
8 checks passed
@philippgille philippgille deleted the rename-proto-package-to-protobuf branch January 21, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants