Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SBOM using Syft #134

Merged
merged 29 commits into from
Feb 18, 2022
Merged

Create SBOM using Syft #134

merged 29 commits into from
Feb 18, 2022

Conversation

Brend-Smits
Copy link
Member

@Brend-Smits Brend-Smits commented Feb 4, 2022

The SBOM is created using tooling from Anchore, called Syft. Syft was chosen because of the ease of use and the good integration with our tech stack.
I think this could have been a separate step in the workflow, but in the end, I chose not to go this route. The reason being is that it will be a lot of repeating the same code and will raise a new problem that we have to upload a temporary artifact or pass along a different output (which may have issues being passed around since the SBOM's can be relatively large in size).

This PR also removes the filter sbom spdx.

This is just a placeholder that should be replaced later with actual sbom content of this project

Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
This commit makes it ready for a pull request, it will only trigger on a release build for now.

It should also be noted that this workflow currently still uses a temporary SBOM SPDX, a new pull request should be created to generate the SBOM

Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
@Brend-Smits Brend-Smits requested a review from a team as a code owner February 4, 2022 09:00
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #134 (30cbe62) into main (91684f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files          15       15           
  Lines         610      610           
=======================================
  Hits          473      473           
  Misses         97       97           
  Partials       40       40           
Flag Coverage Δ
unittests 77.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91684f3...30cbe62. Read the comment docs.

Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
.goreleaser.draft.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
@Brend-Smits Brend-Smits linked an issue Feb 10, 2022 that may be closed by this pull request
JeroenKnoops
JeroenKnoops previously approved these changes Feb 10, 2022
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.goreleaser.draft.yml Outdated Show resolved Hide resolved
.goreleaser.draft.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
Yaml formatting and cosign{-installer} version
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Copy link
Member

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still would like to check using crane and local commandline from a created draft release using the current state of the PR all this sboms and things are accordingly released to ensure also the goreleaser configs are accurate.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
… it getting stuck

Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
Signed-off-by: Brend Smits <brend.smits@philips.com>
@Brend-Smits
Copy link
Member Author

https://github.com/philips-labs/slsa-provenance-action/runs/5235719140?check_suite_focus=true
Feel free to test with Crane @marcofranssen
It's ready for merge. On merge, please Squash the commits.

@Brend-Smits Brend-Smits merged commit 0ffd7f6 into main Feb 18, 2022
@Brend-Smits Brend-Smits deleted the feature/create-sbom branch February 18, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate SBOM
3 participants