-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💚 Only trigger CI when relevant code changes #56
Conversation
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 4 4
Lines 210 210
=======================================
Hits 175 175
Misses 24 24
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Closes #57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing some files.
- Dockerfile
- .goreleaser.yml
Maybe more.
I think we should only disable CODECOV results when no code has been changed. ( only disable
I think running the normal tests on dependabot changes is valuable. We should also run them on releases.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can exclude files instead of include?
Oh yes, fully agree, dependabot will now indeed not run the ci. Should we really go into complicating the pipeline to skip codecov after all? What will we win there? |
In the issue #57 I propose two possible solutions.. maybe adding the CODECOV token in dependabot secret is the better solution. |
https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#onpushpull_requestpaths
Auto merge is enabled - Squashing commits.