Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Only trigger CI when relevant code changes #56

Closed
wants to merge 2 commits into from

Conversation

Brend-Smits
Copy link
Member

@Brend-Smits Brend-Smits commented Oct 18, 2021

@Brend-Smits Brend-Smits requested a review from a team as a code owner October 18, 2021 06:46
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #56 (d9e7e77) into main (2c4e21f) will not change coverage.
The diff coverage is n/a.

❗ Current head d9e7e77 differs from pull request most recent head 6821bf8. Consider uploading reports for the commit 6821bf8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           4        4           
  Lines         210      210           
=======================================
  Hits          175      175           
  Misses         24       24           
  Partials       11       11           
Flag Coverage Δ
unittests 83.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4e21f...6821bf8. Read the comment docs.

@Brend-Smits Brend-Smits changed the title 💚 Only trigger CI when code changes 💚 Only trigger CI when relevant code changes Oct 18, 2021
@Brend-Smits Brend-Smits enabled auto-merge (squash) October 18, 2021 06:49
@JeroenKnoops
Copy link
Member

JeroenKnoops commented Oct 18, 2021

Closes #57

Copy link
Member

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing some files.

  • Dockerfile
  • .goreleaser.yml

Maybe more.

@JeroenKnoops
Copy link
Member

JeroenKnoops commented Oct 18, 2021

I think we should only disable CODECOV results when no code has been changed. ( only disable

- name: Upload Code Coverage
)

I think running the normal tests on dependabot changes is valuable.

We should also run them on releases..

@JeroenKnoops JeroenKnoops self-requested a review October 18, 2021 07:42
Copy link
Member Author

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can exclude files instead of include?

@marcofranssen
Copy link
Member

I think we should only disable CODECOV results when no code has been changed. I think running the normal tests on dependabot changes is valuable.

We should also run them on releases..

Oh yes, fully agree, dependabot will now indeed not run the ci.

Should we really go into complicating the pipeline to skip codecov after all? What will we win there?

@JeroenKnoops
Copy link
Member

In the issue #57 I propose two possible solutions.. maybe adding the CODECOV token in dependabot secret is the better solution.

auto-merge was automatically disabled October 18, 2021 07:56

Pull request was closed

@Brend-Smits Brend-Smits deleted the feature/trigger-ci-limitations branch October 21, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants