Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the variable really named "enable_enable_fifo_build_queue"? #2852

Closed
mariusfilipowski opened this issue Jan 4, 2023 · 1 comment
Closed

Comments

@mariusfilipowski
Copy link
Contributor

mariusfilipowski commented Jan 4, 2023

I just tried out to check the 2.0.2 version with the "simple" runner as it was availble in 1.x.
While migrating the variable names I stumbled upon enable_enable_fifo_build_queue (with doubled enable_):

variable "enable_enable_fifo_build_queue" {

name = "${var.prefix}-queued-builds${var.enable_enable_fifo_build_queue ? ".fifo" : ""}"

Is this correct? In the release notes and the deprecation warning it says that DEPCRECATED, replaced by enable_fifo_build_queue is the correct one: https://github.com/philips-labs/terraform-aws-github-runner/releases/tag/v2.0.1

Looks like a bug to me. But I am not sure.

@npalm
Copy link
Member

npalm commented Jan 5, 2023

Thanks for reporting, will provide a fix. This is indeed a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants