Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correction enable_enable_fifo_build_queue #2857

Merged
merged 2 commits into from Jan 6, 2023
Merged

fix: Correction enable_enable_fifo_build_queue #2857

merged 2 commits into from Jan 6, 2023

Conversation

npalm
Copy link
Member

@npalm npalm commented Jan 5, 2023

Variable fifo_build_queue was replaced by enable_enable_fifo_build_queue but this should be enable_fifo_build_queue.

  • Added enable_enable_fifo_build_queue to depcreated variables so users get a warning what to fix.
  • Replaced enable_enable_fifo_build_queue by enable_fifo_build_queue

@npalm
Copy link
Member Author

npalm commented Jan 5, 2023

fix #2852 #2853

@npalm
Copy link
Member Author

npalm commented Jan 5, 2023

@mcaulifn @mariusfilipowski can you review the PR?

@npalm npalm merged commit 455e272 into main Jan 6, 2023
@npalm npalm deleted the npalm/fix/incorrect-var-name branch January 6, 2023 07:37
@forest-releaser forest-releaser bot mentioned this pull request Jan 6, 2023
Merged
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaNavdeep1983 GuptaNavdeep1983 GuptaNavdeep1983 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@npalm @GuptaNavdeep1983