The bash script in webhook-github-app ignores the -ws and -we parameters and always attempts to fetch from TF state

[rgrama]

https://github.com/philips-labs/terraform-aws-github-runner/blob/main/modules/webhook-github-app/bin/update-app.sh#L33-L43

while getopts a:f:k:ws:we:h flag
do
    case "${flag}" in
        a) APP_ID=${OPTARG};;
        f) APP_PRIVATE_KEY_FILE=${OPTARG};;
        k) APP_PRIVATE_KEY_BASE64=${OPTARG};;
        we) WEBHOOK_ENDPOINT=${OPTARG};;
        ws) WEBHOOK_SECRET=${OPTARG};;
        h) usages ;;
    esac
done

If you echo $flag in that while loop you'll see that each of the letters are printed individually which means we and ws will not be set.

an alternative to that while loop:

while [[ "$#" -gt 0 ]]; do
    case "$1" in
        -a) APP_ID="$2"; shift ;;
        -f) APP_PRIVATE_KEY_FILE="$2"; shift ;;
        -k) APP_PRIVATE_KEY_BASE64="$2"; shift ;;
        -ws) WEBHOOK_SECRET="$2"; shift ;;
        -we) WEBHOOK_ENDPOINT="$2"; shift ;;
        -h) usages ;;
        *) echo "Unknown option passed: $1"; exit 1 ;;
    esac
    shift
done

[npalm]

Thanks for taking time to create an issue, feel free to suggest the change in a PR.