Default to not attching AmazonSSMManagedInstanceCore to instances #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryNguyen5
force-pushed
the
feature/lock_down_ssm_perms
branch
from
930452d
to
1c2b7fe
Compare
npalm
requested changes
Aug 18, 2020
HenryNguyen5
force-pushed
the
feature/lock_down_ssm_perms
branch
from
1c2b7fe
to
a48a6d8
Compare
npalm
requested changes
Aug 19, 2020
There was a problem hiding this comment.
@HenryNguyen5 please check the build, terraform format is failing. The repo has configured https://pre-commit.com/ run terraform format on commint and update the variables in the readme.
HenryNguyen5
force-pushed
the
feature/lock_down_ssm_perms
branch
from
a48a6d8
to
2c236b3
Compare
|
@npalm should be good now! |
HenryNguyen5
force-pushed
the
feature/lock_down_ssm_perms
branch
from
2c236b3
to
2bf5e1a
Compare
|
Rebased |
|
@HenryNguyen5 thanks for updating, just checked the PR. Seems the permissions are set twice in the runner module. To disable the SSM we need to remove a bit more. Please can you remove |
|
@npalm removed! |
|
@npalm anything I should do to push this along? |
npalm
approved these changes
Aug 25, 2020
Thank, looks all good. We will merge asap |
npalm
pushed a commit
that referenced
this pull request
Aug 25, 2020
…es (#143) * Default to not attching AmazonSSMManagedInstanceCore to instances * Remove instance_runner_session_manager_policy
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables AmazonSSMManagedInstanceCore policy attachment to runner instances unless the
debug_instancesvariable is set.Related issue:
#114