Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runners): refactor test to avoid random failing tests #3432

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

npalm
Copy link
Member

@npalm npalm commented Aug 15, 2023

Tests for scale down are failing random.

  • Fixed test data to esnue scale down is always slecting the same runner to be terminated. This was causing the random failure.
  • Cleanup the test file a bit, aka boys scout rule

@npalm npalm force-pushed the chore/npalm/scale-down-test branch from e75966e to 49f0102 Compare August 15, 2023 14:49
@npalm npalm merged commit 446dfec into main Aug 16, 2023
20 checks passed
@npalm npalm deleted the chore/npalm/scale-down-test branch August 16, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants