feat: Have sudo run the user's shell when calling config.sh from start-runner.sh #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshelton229
changed the title
bshelton229
force-pushed
the
sudo-config-shell-login
branch
from
6d445f5
to
2c17cdb
Compare
|
I also don't see any negative side effects. However I want to run some tests. Can you share some details about your setup?
|
|
@bshelton229 please can you check my comment? Also not sure if there is really no impact. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a really interesting issue where we want the
$PATHfrom the$run_asuser's shell. Mostly things that are configured in the bash rc files, like~/.local/bin, which aren't present in the base system path. I couldn't find a better way to do this. It appears the.pathfile is written by theconfig.shscript, and is then locked into place. I think that happens here - https://github.com/actions/runner/blob/72559572f64f40554d43cfa04e4128725dc2274b/src/Misc/layoutroot/env.sh#L37. We're currently running from AMIs built with this patch.The
-iflag, according to sudo, willRun the shell specified by the target user's password database entry as a login shell. .... Because it enters the shell, it resets PWD back to the home folder of the user, hence setting the full path of theconfig.shscript when calling it.I can't think of any negative consequences to this, but it's definitely likely to cause runners to have a different path than they do now.