fix(lambda): Prevent scale-up lambda from starting runner for user repo if org level runners is enabled #3909
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
May 30, 2024 in 39s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method scale-up.ts: scaleUp 🔥
✅ Improving Code Health:
- Overall Code Complexity scale-up.ts 🔥
Annotations
Check warning on line 261 in lambdas/functions/control-plane/src/scale-runners/scale-up.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
scaleUp increases in cyclomatic complexity from 23 to 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in lambdas/functions/control-plane/src/scale-runners/scale-up.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.92 to 4.79, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading