Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variable and fix variables descriptions #75

Merged
merged 4 commits into from Jul 20, 2020
Merged

Rename variable and fix variables descriptions #75

merged 4 commits into from Jul 20, 2020

Conversation

leoblanc
Copy link
Contributor

I'm providing this PR to fix #51. It just fixes a typo in a variable name. It also fixes the descriptions of two other variables.

Description of the Change

  • Renamed variable 'runners_maxiumum_count' as 'runners_maximum_count'
  • Fixed descriptions of runners_scale_down and runners_scale_up variables

Release Notes

  • Renamed variable 'runners_maxiumum_count' as 'runners_maximum_count'.
  • Fixed descriptions of runners_scale_down and runners_scale_up variables

@leoblanc leoblanc mentioned this pull request Jul 16, 2020
Closed
bendavies
bendavies reviewed Jul 16, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
leoblanc and others added 2 commits July 16, 2020 12:55
@leoblanc @bendavies
Update modules/runners/variables.tf
879241d 
Co-authored-by: Ben Davies <ben@owsy.com>
@leoblanc @bendavies
Update variables.tf
6bc16a8 
Co-authored-by: Ben Davies <ben@owsy.com>
@leoblanc
Copy link
Contributor Author

@bendavies Thanks!

npalm
npalm approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoblanc thanks look all good

@npalm npalm merged commit 31d94c5 into philips-labs:develop Jul 20, 2020
@leoblanc
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendavies bendavies bendavies left review comments

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename runners_maxiumum_count input (typo)
3 participants
@leoblanc @bendavies @npalm