fix: UpgradePackBuilderFacade setting mbedtls global memory pool on stack #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue Reproduction
1- Create ConnectionMbedTls
2- Run UpgradePackBuilderFacade
3- Attempt to create ConnectionMbedTls for another host
4- Observe failure on
mbedtls_ssl_session_free()
Details
FATAL: mbedtls_free() outside of managed space
is printed. This indicates either the memory pool is corrupted or the pointers. In this case, mbedtls memory pool is set to stack memory while initialization of a ConnectionMbedTls had been done on the heap. When ConnectionMbedTls tries to free its resources in the pool, because the pool has changed, this operation becomes invalid and causes the program to exit.