Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze script to verify license information from various sources #74

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

JeroenKnoops
Copy link
Member

Add analyze scripts to compare license information from various sources.

Will be used in a blog post

Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I haven't tested it yet but this looks great.
I recommend adding a simple section to the README that describes this tool and how to use it (keep it short, link to blog for more information).

scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/shared.yml Show resolved Hide resolved
@JeroenKnoops
Copy link
Member Author

JeroenKnoops commented Nov 3, 2021

Nice work, I haven't tested it yet but this looks great. I recommend adding a simple section to the README that describes this tool and how to use it (keep it short, link to blog for more information).
I will add this section after the blog is finished.. Now the blog is waiting for these scripts to be in the main.

See #83

@JeroenKnoops JeroenKnoops marked this pull request as ready for review November 3, 2021 07:58
@JeroenKnoops JeroenKnoops requested a review from a team as a code owner November 3, 2021 07:58
Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks thanks to ShellCheck.

scripts/analyze-all.sh Outdated Show resolved Hide resolved
scripts/analyze-all.sh Outdated Show resolved Hide resolved
scripts/analyze-all.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
scripts/analyze.sh Outdated Show resolved Hide resolved
@JeroenKnoops
Copy link
Member Author

I will squash to commits..

@Brend-Smits
Copy link
Member

I will squash to commits..

For future reference, you can bundle these suggestions via the Files Changed tab😀

…ate the results

Co-authored-by: Brend Smits <brend.smits@philips.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants