Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dicom: Repository Create call even if it already exists in state file #297

Closed
soubhagya-pradhan opened this issue Jan 11, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@soubhagya-pradhan
Copy link

Hi,
HSDP Terraform version : v0.38.13
Dicom repository is created with older hsdp terraform. Upgrading to >0.38.13 the plan shows creation of hsdp_repository, however the tf state file has the entry of resource.
TF Plan:

# module.dicomstore_onboard[0].module.dicomstore_tenant_orgs_onboard["ff599ed4-5401-44d6-a85e-ca439b591907"].hsdp_dicom_repository.dicom_repository will be created
  + resource "hsdp_dicom_repository" "dicom_repository" {
      + config_url      = "https://xxxxxxxxxxxxxxxx.us-east.philips-healthsuite.com/"
      + id              = (known after apply)
      + object_store_id = "xxxxxxxxxxxxxxxxxx"
      + organization_id = "ff599ed4-5401-44d6-a85e-ca439b591907"
      + notification {
          + enabled         = true
          + organization_id = "ff599ed4-5401-44d6-a85e-ca439b591907"
        }
    }

State Entry:

"module": "module.dicomstore_onboard[0].module.dicomstore_tenant_orgs_onboard[\"ff599ed4-5401-44d6-a85e-ca439b591907\"]",
      "mode": "managed",
      "type": "hsdp_dicom_repository",
      "name": "dicom_repository",
      "provider": "provider[\"[registry.terraform.io/philips-software/hsdp](http://registry.terraform.io/philips-software/hsdp)\"]",
      "instances": [
        {
          "schema_version": 1,
          "attributes": {
            "config_url": "https://xxxxxxxxxx.us-east.philips-healthsuite.com/",
            "id": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
            "notification": [
              {
                "enabled": true,
                "organization_id": "ff599ed4-5401-44d6-a85e-ca439b591907"
              }
            ],
            "object_store_id": "xxxxxxxxxxxxxxxxxxxxx",
            "organization_id": "ff599ed4-5401-44d6-a85e-ca439b591907",
            "repository_organization_id": null,
            "store_as_composite": null
          },
          "sensitive_attributes": [],
          "private": "bnVsbA==",
          "dependencies": [
            "data.azurerm_key_vault.secrets",
            "data.azurerm_key_vault_secret.hsdp_secrets",
            "data.azurerm_key_vault_secret.s3_secrets",
            "data.azurerm_resource_group.edi_platform",
            "hsdp_iam_proposition.prop_edi_platform",
            "module.dicomstore_onboard.data.hsdp_config.current_session",
            "module.dicomstore_onboard.data.hsdp_iam_service.automation_service_identity",
            "module.dicomstore_onboard.hsdp_iam_group.grp_s3_creds_admin",
            "module.dicomstore_onboard.hsdp_iam_role.role_s3_creds_admin",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.data.hsdp_config.current_session",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.data.hsdp_iam_service.automation_service_identity",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.hsdp_dicom_object_store.object_store",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.hsdp_iam_application.app_dicom_s3creds",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.hsdp_iam_group.grp_dicom_admin",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.hsdp_iam_role.role_dicom_admin",
            "module.dicomstore_onboard.module.dicomstore_tenant_orgs_onboard.hsdp_iam_service.svc_dicom_s3creds"
          ]
        }
      ] 
@soubhagya-pradhan soubhagya-pradhan changed the title Dicom: Repository Create call even it already exists in state file Dicom: Repository Create call even if it already exists in state file Jan 11, 2023
@loafoe loafoe added the bug Something isn't working label Jan 11, 2023
loafoe added a commit that referenced this issue Jan 16, 2023
Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
@loafoe
Copy link
Member

loafoe commented Jan 17, 2023

As discussed, issue seems to be resolved now, closing

@loafoe loafoe closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants