Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for improved test coverage #23

Open
mfarid opened this issue Jan 17, 2016 · 2 comments
Open

Unit Tests for improved test coverage #23

mfarid opened this issue Jan 17, 2016 · 2 comments

Comments

@mfarid
Copy link

mfarid commented Jan 17, 2016

Hi Philip

My name is Farid. I'm a developer with great interest in making open source contributions to popular projects.

My company - DevFactory - is sponsoring me to improve unit test coverage in open source projects.

I have analyzed angular-rest-springsecurity and observed that there is room for improvement of coverage. The results indicate that the project has:

Coverage: 0%, Total Lines: 736

If you are interested in having us work towards improving the project’s coverage to 80%, please let me know and we will add it to our pipeline. Our first step will be to create a pull request with a sample. Once you approve it, we'll follow up with one or two more pull requests. Our target is to increase code coverage to above 80 percent.

For an example of our work, please see these Pull Requests accepted by the community:

I'm looking forward to your confirmation.

Thank you,
Mohd Farid
Open Source Code Coverage Team
DevFactory

@sesepehr
Copy link

hi
thanks for recommendation,
Thank you

sepehr naderi

On Sun, Jan 17, 2016 at 11:07 AM, Mohd Farid notifications@github.com
wrote:

Hi Philip

My name is Farid. I'm a developer with great interest in making open
source contributions to popular projects.

My company - DevFactory - is sponsoring me to improve unit test coverage
in open source projects.

I have analyzed angular-rest-springsecurity and observed that there is
room for improvement of coverage. The results indicate that the project has:

Coverage: 0%, Total Lines: 736

If you are interested in having us work towards improving the project’s
coverage to 80%, please let me know and we will add it to our pipeline. Our
first step will be to create a pull request with a sample. Once you approve
it, we'll follow up with one or two more pull requests. Our target is to
increase code coverage to above 80 percent.

For an example of our work, please see these Pull Requests accepted by the
community:

I'm looking forward to your confirmation.

Thank you,
Mohd Farid
Open Source Code Coverage Team
DevFactory


Reply to this email directly or view it on GitHub
#23.

@mfarid
Copy link
Author

mfarid commented Jan 20, 2016

I have raised a small Pull Request that introduces testing into the project. It also tests TokenUtils class. Please review the same and share feedback.
#24

Once you approve the same, I will raise a PR for the rest of the classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants