Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ctrl+n/p for selection #80

Closed
gwimm opened this issue Feb 26, 2023 · 3 comments
Closed

Support Ctrl+n/p for selection #80

gwimm opened this issue Feb 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@gwimm
Copy link

gwimm commented Feb 26, 2023

arrow keys are too far away.

@philj56 philj56 added the enhancement New feature or request label Feb 26, 2023
@philj56
Copy link
Owner

philj56 commented Feb 26, 2023

Done in 81560bb (you can also use Ctrl+j/k by the way). At some point, I really should make keybinds customisable.

@philj56 philj56 closed this as completed Feb 26, 2023
@kpe
Copy link

kpe commented Apr 16, 2023

(I like your project) It looks however that the Ctrl+p/n/j/k bindings don't respect the keyboard/input layout. I'm using a non-standard layout/variant (dvorak) and was wondering why the binding don't work, until I found out, that they work if I actually press the j/k/p/n keys, where they usually would be if I use the standard us layout.

So prabably replacing KEY_P with XKB_KEY_P, etc would work as expected.

@philj56
Copy link
Owner

philj56 commented Apr 16, 2023

This is deliberate: see #62 & #41 for more info. Basically, there's no way I know of to make it work correctly for both non-Latin and non-QWERTY Latin keyboards.

I keep saying this, but I really do need to look into customisable keybindings at some point. I'll have to make it the next thing I do after I finish what I'm currently working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants