Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: extract subtitle #14

Merged
merged 2 commits into from
Mar 29, 2022
Merged

notification: extract subtitle #14

merged 2 commits into from
Mar 29, 2022

Conversation

phillco
Copy link
Owner

@phillco phillco commented Mar 29, 2022

The "subtitle" field is used in some notifications. For example, in Slack it's name of the person DMing you if the message comes from a different community, e.g. here "Slackbot"

Screen Shot 2022-03-28 at 4 44 19 PM

Also rename actions to group_actions so it doesn't shadow the outer import name.

@phillco phillco requested a review from nriley as a code owner March 29, 2022 01:14
Copy link
Collaborator

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it locally but looks good upon inspection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants