Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyhton version does not handle unused connected displays #13

Closed
RasmusWL opened this issue Jan 22, 2015 · 1 comment
Closed

Pyhton version does not handle unused connected displays #13

RasmusWL opened this issue Jan 22, 2015 · 1 comment
Assignees

Comments

@RasmusWL
Copy link
Contributor

Thanks for keeping this project going. I started building my own Python version from scrap after realising that the wertabyte repo didn't work. (if you're in touch with him, maybe you can ask him to put a disclaimer on the top of the readme?)

Currently your python version does not work. If there's a display connected, but not currently used by xrandr, I get the current output:

LVDS1 connected (normal left inverted right x axis y axis)

However, your RegEx requires that if a display is connected, it must also have <with>x<height>+<x>+<y>, which is clearly not true.


The main point is: a display can be connected, but not in use. This means there are 3 statuses: (1) in use, (2) idle (connected but not in use), (3) disconnected.

Currently your code relies on the "off" property for most of it's logic, so this is a non-trivial change which I think is better left off to you 😄

@phillipberndt
Copy link
Owner

Thanks! wertabyte seems to be quite occupied, I doubt that he'll take the effort. (He didn't even add a note that autorandr is GPL to his readme, it's hidden in the issues section..)

A display that is connected, but unused in the current configuration, is still --off to xrandr, unless I don't get your use-case correctly. Does 2181c8e resolve this for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants