Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Start pqiv with otherwise default options and keybindings, with a filename as argument
Press
Escape
Press
f
(as often as you like)Expected behavior:
f
in step 4 toggles fullscreen modeObserved behavior: nothing happens.
Root cause:
a) The
Escape
in step 3 tries to leave fullscreen even when fullscreen is not active.b) window_unfullscreen() then tries to set main_window_in_fullscreen to
FALSE
temporarily (even though it already wasFALSE
) then "restore" it incorrectly by setting it toTRUE
.c) This means main_window_in_fullscreen is now out of sync with reality.
d) From this point on, any attempt to toggle it will try to toggle it in the wrong direction.
Debug trace (pressed
Escape
once, thenf
twice):