Added test for .createAttachment method.

philliphenslee · Oct 25, 2015 · efbac51 · efbac51
1 parent 0fe0f73
commit efbac51
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -71,9 +71,6 @@ util.inherits(SmartSlack, EventEmitter);
  * @return {object} Attachment The attachment instance
  */
 SmartSlack.prototype.createAttachment = function(text) {
-    if (!_.isString(text)) {
-        throw new Error(errors.missing_required_arg);
-    }
     return new Attachment(text);
 };
 

diff --git a/lib/slack/api.js b/lib/slack/api.js
@@ -37,7 +37,7 @@ function post(method, options, callback) {
     if (options.attachments) {
         options.attachments = JSON.stringify(options.attachments);
     }
-    console.log(options);
+
     var postData = querystring.stringify(options);
 
     var requestOptions = {
@@ -90,5 +90,5 @@ function post(method, options, callback) {
     request.write(postData);
     request.end();
 }
-
 module.exports.post = post;
+
diff --git a/test/index.spec.js b/test/index.spec.js
@@ -57,13 +57,29 @@ describe('SmartSlack', function () {
         });
     });
 
+    describe('#createAttachment', function () {
+
+        it('exists as method on SmartSlack', function (done) {
+            var slackClient = new SmartSlack(mockopts);
+            expect(typeof slackClient.createAttachment).to.equal('function');
+            done();
+        });
+        it('should return an attachment object instance', function (done) {
+            var slackClient = new SmartSlack(mockopts);
+            var attachment = slackClient.createAttachment('The attachment text');
+            expect(attachment).to.be.an('object');
+            expect(attachment.text).to.equal('The attachment text');
+            done();
+        });
+    });
+
     describe('#start', function () {
 
         it('exists as method on SmartSlack', function (done) {
             var slackClient = new SmartSlack(mockopts);
             expect(typeof slackClient.start).to.equal('function');
             done();
-        })
+        });
     });
 
     describe('#postDirectMessage', function () {