Add support for https parameter to force https even on non-443 port
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compatible
| @@ -18,6 +18,7 @@ function PlexAPI(options, deprecatedPort) { | |||
|
|
|||
| this.hostname = hostname; | |||
| this.port = deprecatedPort || opts.port || PLEX_SERVER_PORT; | |||
| this.https = opts.https || false; | |||
There was a problem hiding this comment.
this.https = opts.https;Could that possibly fix the (rare) issue you're describing?
There is a teeny tiny corner case issue which I think is acceptable for the sake of backwards compatibility: if you supply both port: 443 and https: false, it will still use https due to the port number.
Cause then line #197 could be
return this.https === true || (this.port === 443 && this.https === undefined) ? 'https://' : 'http://';There was a problem hiding this comment.
Yep, that makes more sense! I'll add another commit. I might break out that logic in to a couple lines because it's becoming a little hard to read for a ternary.
There was a problem hiding this comment.
I might break out that logic in to a couple lines ...
👍
|
Should be ready for merging now :) |
|
Nice 👍 |
phillipj
added a commit
that referenced
this pull request
Jan 14, 2016
Add support for `https` parameter to force https even on non-443 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible!
This is necessary for connecting directly to plex media servers securely when they are running not on port 443 (which is always). I have tested this is an actual app and it works :)
There is a teeny tiny corner case issue which I think is acceptable for the sake of backwards compatibility: if you supply both
port: 443andhttps: false, it will still use https due to the port number. I can't imagine this will ever come up in a legitimate scenario though.