Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Removed unnecessary if/else #39

Merged
merged 1 commit into from Jan 3, 2013
Merged

[minor] Removed unnecessary if/else #39

merged 1 commit into from Jan 3, 2013

Conversation

juzerali
Copy link
Contributor

@juzerali juzerali commented Jan 2, 2013

@phillro: Is this good to merge?

@juzerali
Copy link
Contributor Author

juzerali commented Jan 3, 2013

I have attached the relevant test case in master branch and rebased this one on top of it. reqOption.path = "_search" and reqOptions.path="/_search" produces the same result, there no difference. Hence the if/else worked. This one however is more generalized and produces following paths for each cases when indexName, objName are present or ommitted:

/your_index_name/your_object_name/_search?options...
/your_index_name/_search?options...
/_search?options...

phillro added a commit that referenced this pull request Jan 3, 2013
@phillro
Merge pull request #39 from juzerali/deploy-ifelsefix
fd0c92a 
[minor] Removed unnecessary if/else
@phillro phillro merged commit fd0c92a into phillro:master Jan 3, 2013
@phillro
Copy link
Owner

phillro commented Jan 3, 2013

Cool. thx.

@juzerali juzerali deleted the deploy-ifelsefix branch January 4, 2013 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juzerali @phillro