Add some basic limits to anonymous tag changes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meow
reviewed
May 11, 2023
Meow
reviewed
May 11, 2023
Meow
reviewed
May 11, 2023
Meow
approved these changes
May 11, 2023
|
Looking over again, I think rating counts aren't checked correctly (always fails the update if a rating tag was changed in the last 10 minutes, even if no rating tag was changed in the current update) |
Meow
requested changes
May 18, 2023
There was a problem hiding this comment.
Looking closer at it, this has not a snowflake's chance in hell to work. Here are the glaring issues which I have noticed looking at the code:
- It's not actually checked if the current change batch contains any rating tags, rather the tagging is rejected if the user has changed any rating tags at all in the past indiscriminately.
I've added a couple of comments on relevant lines and my suggestions for fixes.
| Limits.is_limited_for_tag_count?(user, ip) -> | ||
| {:error, "Limit exceeded"} | ||
|
|
||
| Limits.is_limited_for_rating_count?(user, ip) -> |
There was a problem hiding this comment.
This needs to check if the current batch contains rating tag changes, otherwise it'll fail the update if user changed rating tag somewhere, but not in this batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.