Skip to content

Commit

Permalink
Fix estimates buttons on small mobile phones
Browse files Browse the repository at this point in the history
In order to display well on mobile screens
- replace width by max-width in css for buttons form
- increase the line spacing in the buttons form
- change an html id from Session to session
- add correct html id for buttons form
  • Loading branch information
philou committed Jun 10, 2017
1 parent 29da948 commit 3fd84b0
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 54 deletions.
53 changes: 8 additions & 45 deletions DayBook.md
Original file line number Diff line number Diff line change
@@ -1,43 +1,14 @@
# TODO Release Alpha

* ~~Doc / home page
* ~~Explain what's the need
* how to use it~~
* ~~where it's available
* limitations
* explain it's open source, with the licence, and that instructions can be found in the repo
* links to the different parts
* the app
* repo
* author
* Ask for feedback~~
* ~~readme
* ~~link badges
* heroku live
* zenhub issues
* what it does
* ~~the vision~~
* ~~run it~~
* ~~how it is deployed~~
* ~~how to deploy it yourself~~
* ~~how to contribute
* issue board
* the 'CI'
* coding conventions
* TDD
* few mocks
* follow standards
* simplest things
* TODOs for technical debt (esp at beginning)~~
* The video
* write down a script
* ~~write down a script~~
* Hi
* goal : demo remote planning poker with philou's planning poker app
* imagine the toons team 3 members : Jerry, Tom and Coyote
* all different place, all different sessions
* they start a phone conference
* they all go to the planning poker homepage
* jerry enters first
* jerry enters first -> animator
* followed by Tom
* they discuss and agree to start estimating a story
* Tom votes 5
Expand All @@ -51,25 +22,17 @@
* twice as many 3s than 5s
* Discussion
* Could re-vote or vote another story
* setup obs
* does not seem to work on retina display
* I'll have to try the quick time stuff
* that's all for the demo
* find it live on heroku, repeat url
* ~~setup quick time~~
* record it
* push it to youtube
* add it to readme
* add it to the homepage
* ~~links at the bottom:
* the author, my blog
* repo, open source
* a doc page
* push~~
~~* make it responsive !
* check the work needed~~
* v0.1
* publish the homepage to social media
* is it published through my rss ?
* twitter ?
* hackernews
* ~~is it published through my rss ?~~ NO
* twitter ? My latest #SideProject, a remote #PlanningPoker app #agile
* hackernews [Show HN] Open Source remote planning poker app

# Next Stories
# Smells
6 changes: 5 additions & 1 deletion app/assets/stylesheets/custom.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ p {
/* Custom element alignment */

#team-vote-countdown {
width: 400px;
max-width: 400px;
margin-left: auto;
margin-right: auto;
}
Expand All @@ -64,4 +64,8 @@ p {

#estimate-histograms {
margin: 2em auto;
}

#estimates-buttons {
line-height: 275%;
}
2 changes: 1 addition & 1 deletion app/views/static_pages/home.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<h1>Philou's Planning Poker</h1>
<p>A planning poker app for agile remote teams</p>

<%= form_tag contributors_path, id: "Session", class: "form-inline" do %>
<%= form_tag contributors_path, id: "session", class: "form-inline" do %>
<%= text_field_tag "Team", "", class: "form-control", placeholder:"Your team" %>
<%= text_field_tag "Name", "", class: "form-control", placeholder: "Your name" %>
<%= submit_tag "Enter", class: "btn btn-default" %>
Expand Down
10 changes: 4 additions & 6 deletions app/views/votes/_running.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@
<div class="lead">
<span id="team-vote-clock" data-vote-ending="<%= vote.ending.iso8601 %>"><%= pluralize(vote.seconds_to_end, "second") %></span> remaining
</div>
<%= form_tag contributor_estimations_path(@contributor), id: "Session", class: "form-inline" do %>
<%= form_tag contributor_estimations_path(@contributor), id: "estimates-buttons", class: "form-inline" do %>
<div class="btn-group">
<% PhilousPlanningPoker::FIBOS.each do |estimate| %>
<% PhilousPlanningPoker::FIBOS.each do |estimate| %>
<%= submit_tag estimate, class: "btn btn-primary", name: "story_points" %>
<%= submit_tag estimate, class: "btn btn-primary", name: "story_points" %>
<% end %>
</div>
<% end %>
<% end %>

Expand Down
2 changes: 1 addition & 1 deletion features/step_definitions/homepage.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
def enter_team_space(contributor_name, team_name)
visit root_path

within("#Session") do
within("#session") do
fill_in 'Team', :with => team_name
fill_in 'Name', :with => contributor_name
end
Expand Down

0 comments on commit 3fd84b0

Please sign in to comment.