Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use javascript instead of coffee-script #113

Merged
merged 16 commits into from
Dec 9, 2016
Merged

Use javascript instead of coffee-script #113

merged 16 commits into from
Dec 9, 2016

Conversation

philschatz
Copy link
Owner

@philschatz philschatz commented Sep 30, 2016

This switches the source code to use .js files instead of .coffee files.

Steps taken so far:

  1. decaffeinate src/**.coffee
    • I needed to skip some files because they did not automatically convert
  2. replace import X from Y with const X = require(Y)
  3. run standard --fix *.js src/**.js to re-lint the files
    • I needed to run eslint directly so I could check that tests pass

TODO

  • decide whether to use ES6 features (like const, class) or convert them to vanilla var
  • manually convert the remaining src/**.coffee files
    • Note: multiline regular expressions in Coffee-Script are nice because they allow comments
  • remove __guard__ function (from decaffeinate)
  • convert the test/**.coffee files

most of the tweaks were to change `import X from Y` to `const X =
require(Y)`
converted using `standard —fix *.js src/**.js`
required some manual conversion in requester.coffee
@philschatz philschatz merged commit b0e7859 into master Dec 9, 2016
@philschatz philschatz deleted the use-javascript branch December 9, 2016 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant