-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use javascript instead of coffee-script #113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most of the tweaks were to change `import X from Y` to `const X = require(Y)`
converted using `standard —fix *.js src/**.js`
required some manual conversion in requester.coffee
philschatz
force-pushed
the
use-javascript
branch
from
November 24, 2016 19:08
ddeb73b
to
2106bac
Compare
because external dependencies have dropped support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the source code to use
.js
files instead of.coffee
files.Steps taken so far:
decaffeinate src/**.coffee
import X from Y
withconst X = require(Y)
standard --fix *.js src/**.js
to re-lint the fileseslint
directly so I could check that tests passTODO
const
,class
) or convert them to vanillavar
src/**.coffee
files__guard__
function (from decaffeinate)test/**.coffee
files