Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was octokit.js forked from michael/github? #52

Closed
cirosantilli opened this issue Jun 1, 2014 · 2 comments
Closed

Why was octokit.js forked from michael/github? #52

cirosantilli opened this issue Jun 1, 2014 · 2 comments

Comments

@cirosantilli
Copy link

Are there different design goals / principles? If yes, which?

@philschatz
Copy link
Owner

Thanks for the interest (and the contributions)!

My original goal was to add support for Promises and have it run in the browser or as a NodeJS package. I also converted the code to coffeescript (for conciseness) and submitted a Pull Request. It took a month or so before getting a response so I just kept adding features and by the time the Pull Req was rejected I had already made significant changes.

If I recall correctly, you were interested in github-tools#68 . Rather than refactor this API it may be easier to use philschatz/octokat.js since it is less hard-coded to GitHub's API. I posted some thoughts on octokat.js at http://philschatz.com

Hope that helps!

@cirosantilli
Copy link
Author

@philschatz Thanks a lot for the explanation.

I am very interested in adding GitLab to a Js GitHub API wrapper so as to implement the largest possible intersection of both with the same interface, and if Shuttleworth or the Catalyst Grant takes me I will put 4 weeks into it.

So you are focusing more on Octokat development now is that it?

I saw GitHub bookeditor is still currently using Octokit, are there plans to shift to Octokat?

Which project would it benefit OER the most to add GitLab support to?

I recommend the octokit vs octokat question be commented in their README to help focus development on the preferred one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants