Exception in CHECK/REQUIRE prints exception message twice and raises assertion-failure counter by two

[StephanDollberg]

If an exception is thrown in a test-case which doesn't except it, the assertion-failure counter is raised by two and the exception message is printed twice.

Example: (using the latest all-in-one file)

Running the following test

#define CATCH_CONFIG_MAIN                                                                            
#include "catch.hpp"

int foo() { throw 234; return 42; }

TEST_CASE("Test/1", "Test") {
    CHECK(foo() == 42);
}

Gives the following output:

test.cpp:8: foo() == 42 failed with unexpected exception with message: 'Unknown exception'
test.cpp:8: foo() == 42 failed with unexpected exception with message: 'Unknown exception'
[Finished: 'Test/1' 1 test case failed (All 2 assertions failed)]

[Testing completed. 1 test case failed (All 2 assertions failed)]

I found a related issue here(#139), however that was supposed to be fixed.

[philsquared]

#139 related to the integration branch (which probably hasn't been merged over since then). Looks like you've found the same issue on Master.
I'd recommend you try integration. It's superiour in many ways and I should be committing it across soon anyway.

[andyprowl]

With the integration branch the second message is slightly different and contains the message "{Unknown expression after the reported line}", but it still counts as if 2 assertions failed instead of one.

[philsquared]

Ah. Thanks for the extra info, Andy.
I'll take a look.

[philsquared]

Found and fixed. Thanks for reporting this guys. Was a silly little spurious (re-)throw statement that got left in at some point.
My tests for throwing exceptions outside of an exception-anticipating assertion threw it directly - but this bug requires you throw from a function - so I was missing it!
Needless to say I've added the function throwing case to my test suite now!

[philsquared]

(Fixed in Integration, that is)

[andyprowl]

Wow, that was fast. Thank you very much :)

[philsquared]

NP. Thanks for letting me know about it