Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disabled VC warning C4702. #199

Closed
wants to merge 8 commits into from

Conversation

Fraser999
Copy link
Contributor

The warning is for unreachable code (around line 166 of clara.h shown below):

virtual void setFlag( C& obj ) const {
    typename RemoveConstRef<T>::type value;
    convertInto( true, value );  // This throws if value is of type std::string
    function( obj, value );  // warning C4702
}

This ultimately comes from bindProcessName, where convertInto has args of type bool and std::string.

@vadz
Copy link
Contributor

vadz commented Jan 9, 2014

It would be nice to find some way to avoid this warning and this commit, while not ideal, would be better than nothing. Getting a couple of these warnings for every (release) build is rather annoying.

@ben-crowhurst
Copy link

+1 These warnings are driving us crazy.

@horenmar
Copy link
Member

I tested this and v1.7.1 does not trigger C4702 warning. Unless someone still has trouble, I am going to close this soon.

@horenmar horenmar added the Resolved - pending review Issue waiting for feedback from the original author label Feb 11, 2017
@vadz
Copy link
Contributor

vadz commented Feb 12, 2017

I can confirm that the warning is gone with 1.7.1, at least when using MSVS 2015. Thanks!

@philsquared
Copy link
Collaborator

Thanks, @vadz

@horenmar horenmar removed the Resolved - pending review Issue waiting for feedback from the original author label Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants