Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if: expression on ci file configuration doesn't work as expected #273

Merged
merged 1 commit into from May 8, 2020
Merged

if: expression on ci file configuration doesn't work as expected #273

merged 1 commit into from May 8, 2020

Conversation

cleidiano
Copy link
Contributor

The current configuration skip configuration on all steps.

@sourcelevel-bot
Copy link

Hello, @cleidiano! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@cleidiano
Copy link
Contributor Author

I will check later why the test have been failed.

@cleidiano
Copy link
Contributor Author

cleidiano commented May 1, 2020

The issue were fixed on InchEx rrrene/inch_ex#68, but not release yet.
It's appropriate to rollback Inch change section or keep this PR open until InchEx release?

@cleidiano
Copy link
Contributor Author

@philss The fix for inch_ex was rollback, after it released 2.1 I can open up a new PR to fix it.

@philss
Copy link
Owner

philss commented May 8, 2020

@cleidiano awesome! Thank you! 💜

I didn't get the problem with InchEx 🤔
But feel free to open a new PR to fix it.

@philss philss merged commit fa46fb7 into philss:master May 8, 2020
@cleidiano
Copy link
Contributor Author

The inch_ex task on CI isn't running because the same problem I have fixed in check-formatted task, but current inch_ex have a bug that crash on parse module that haven't docs chunk on beam file, for example floki_mochi_html.erl.
To fix the inch_ex task we need to await for release 2.1 that fix de problem, for reference rrrene/inch_ex#68

@cleidiano cleidiano deleted the cos/fix-ci-expression branch May 8, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants