Verify that given targets are supported by Rust (#19)

* Verify that given targets are supported by Rust

* Fix typo

* Require targets to be a non-empty list

lib/rustler_precompiled.ex

@@ -42,7 +42,7 @@ defmodule RustlerPrecompiled do
 
     * `:targets` - A list of targets [supported by
       Rust](https://doc.rust-lang.org/rustc/platform-support.html) for which
-      precompiled assets are avilable. By default the following targets are
+      precompiled assets are available. By default the following targets are
       configured:
 
     #{Enum.map_join(RustlerPrecompiled.Config.default_targets(), "\n", &"    - `#{&1}`")}

lib/rustler_precompiled/config.ex

@@ -1,6 +1,8 @@
 defmodule RustlerPrecompiled.Config do
   @moduledoc false
 
+  alias __MODULE__.AvailableTargets
+
   # This is an internal struct to represent valid config options.
   defstruct [
     :otp_app,
@@ -71,14 +73,24 @@ defmodule RustlerPrecompiled.Config do
 
   defp validate_targets!(nil), do: raise_for_nil_field_value(:targets)
 
-  defp validate_targets!(targets) do
-    if is_list(targets) do
-      targets
-    else
-      raise "`:targets` is required to be a list of targets supported by Rust"
+  defp validate_targets!([_ | _] = targets) do
+    case targets -- AvailableTargets.list() do
+      [] ->
+        targets
+
+      invalid_targets ->
+        raise """
+        `:targets` contains targets that are not supported by Rust:
+
+        #{inspect(invalid_targets, pretty: true)}
+        """
     end
   end
 
+  defp validate_targets!(_targets) do
+    raise "`:targets` is required to be a list of targets supported by Rust"
+  end
+
   defp raise_for_nil_field_value(field) do
     raise "`#{inspect(field)}` is required for `RustlerPrecompiled`"
   end

lib/rustler_precompiled/config/available_targets.ex

@@ -0,0 +1,192 @@
+defmodule RustlerPrecompiled.Config.AvailableTargets do
+  @moduledoc false
+
+  @doc """
+  The list of Rust's built-in targets.
+
+  To update run `rustc --print target-list`.
+  """
+  def list do
+    ~w(
+      aarch64-apple-darwin
+      aarch64-apple-ios
+      aarch64-apple-ios-macabi
+      aarch64-apple-ios-sim
+      aarch64-apple-tvos
+      aarch64-fuchsia
+      aarch64-kmc-solid_asp3
+      aarch64-linux-android
+      aarch64-pc-windows-msvc
+      aarch64-unknown-freebsd
+      aarch64-unknown-hermit
+      aarch64-unknown-linux-gnu
+      aarch64-unknown-linux-gnu_ilp32
+      aarch64-unknown-linux-musl
+      aarch64-unknown-netbsd
+      aarch64-unknown-none
+      aarch64-unknown-none-softfloat
+      aarch64-unknown-openbsd
+      aarch64-unknown-redox
+      aarch64-unknown-uefi
+      aarch64-uwp-windows-msvc
+      aarch64-wrs-vxworks
+      aarch64_be-unknown-linux-gnu
+      aarch64_be-unknown-linux-gnu_ilp32
+      arm-linux-androideabi
+      arm-unknown-linux-gnueabi
+      arm-unknown-linux-gnueabihf
+      arm-unknown-linux-musleabi
+      arm-unknown-linux-musleabihf
+      armebv7r-none-eabi
+      armebv7r-none-eabihf
+      armv4t-unknown-linux-gnueabi
+      armv5te-unknown-linux-gnueabi
+      armv5te-unknown-linux-musleabi
+      armv5te-unknown-linux-uclibceabi
+      armv6-unknown-freebsd
+      armv6-unknown-netbsd-eabihf
+      armv6k-nintendo-3ds
+      armv7-apple-ios
+      armv7-linux-androideabi
+      armv7-unknown-freebsd
+      armv7-unknown-linux-gnueabi
+      armv7-unknown-linux-gnueabihf
+      armv7-unknown-linux-musleabi
+      armv7-unknown-linux-musleabihf
+      armv7-unknown-linux-uclibceabi
+      armv7-unknown-linux-uclibceabihf
+      armv7-unknown-netbsd-eabihf
+      armv7-wrs-vxworks-eabihf
+      armv7a-kmc-solid_asp3-eabi
+      armv7a-kmc-solid_asp3-eabihf
+      armv7a-none-eabi
+      armv7a-none-eabihf
+      armv7r-none-eabi
+      armv7r-none-eabihf
+      armv7s-apple-ios
+      asmjs-unknown-emscripten
+      avr-unknown-gnu-atmega328
+      bpfeb-unknown-none
+      bpfel-unknown-none
+      hexagon-unknown-linux-musl
+      i386-apple-ios
+      i586-pc-windows-msvc
+      i586-unknown-linux-gnu
+      i586-unknown-linux-musl
+      i686-apple-darwin
+      i686-linux-android
+      i686-pc-windows-gnu
+      i686-pc-windows-msvc
+      i686-unknown-freebsd
+      i686-unknown-haiku
+      i686-unknown-linux-gnu
+      i686-unknown-linux-musl
+      i686-unknown-netbsd
+      i686-unknown-openbsd
+      i686-unknown-uefi
+      i686-uwp-windows-gnu
+      i686-uwp-windows-msvc
+      i686-wrs-vxworks
+      m68k-unknown-linux-gnu
+      mips-unknown-linux-gnu
+      mips-unknown-linux-musl
+      mips-unknown-linux-uclibc
+      mips64-openwrt-linux-musl
+      mips64-unknown-linux-gnuabi64
+      mips64-unknown-linux-muslabi64
+      mips64el-unknown-linux-gnuabi64
+      mips64el-unknown-linux-muslabi64
+      mipsel-sony-psp
+      mipsel-unknown-linux-gnu
+      mipsel-unknown-linux-musl
+      mipsel-unknown-linux-uclibc
+      mipsel-unknown-none
+      mipsisa32r6-unknown-linux-gnu
+      mipsisa32r6el-unknown-linux-gnu
+      mipsisa64r6-unknown-linux-gnuabi64
+      mipsisa64r6el-unknown-linux-gnuabi64
+      msp430-none-elf
+      nvptx64-nvidia-cuda
+      powerpc-unknown-freebsd
+      powerpc-unknown-linux-gnu
+      powerpc-unknown-linux-gnuspe
+      powerpc-unknown-linux-musl
+      powerpc-unknown-netbsd
+      powerpc-unknown-openbsd
+      powerpc-wrs-vxworks
+      powerpc-wrs-vxworks-spe
+      powerpc64-unknown-freebsd
+      powerpc64-unknown-linux-gnu
+      powerpc64-unknown-linux-musl
+      powerpc64-wrs-vxworks
+      powerpc64le-unknown-freebsd
+      powerpc64le-unknown-linux-gnu
+      powerpc64le-unknown-linux-musl
+      riscv32gc-unknown-linux-gnu
+      riscv32gc-unknown-linux-musl
+      riscv32i-unknown-none-elf
+      riscv32im-unknown-none-elf
+      riscv32imac-unknown-none-elf
+      riscv32imc-esp-espidf
+      riscv32imc-unknown-none-elf
+      riscv64gc-unknown-freebsd
+      riscv64gc-unknown-linux-gnu
+      riscv64gc-unknown-linux-musl
+      riscv64gc-unknown-none-elf
+      riscv64imac-unknown-none-elf
+      s390x-unknown-linux-gnu
+      s390x-unknown-linux-musl
+      sparc-unknown-linux-gnu
+      sparc64-unknown-linux-gnu
+      sparc64-unknown-netbsd
+      sparc64-unknown-openbsd
+      sparcv9-sun-solaris
+      thumbv4t-none-eabi
+      thumbv6m-none-eabi
+      thumbv7a-pc-windows-msvc
+      thumbv7a-uwp-windows-msvc
+      thumbv7em-none-eabi
+      thumbv7em-none-eabihf
+      thumbv7m-none-eabi
+      thumbv7neon-linux-androideabi
+      thumbv7neon-unknown-linux-gnueabihf
+      thumbv7neon-unknown-linux-musleabihf
+      thumbv8m.base-none-eabi
+      thumbv8m.main-none-eabi
+      thumbv8m.main-none-eabihf
+      wasm32-unknown-emscripten
+      wasm32-unknown-unknown
+      wasm32-wasi
+      wasm64-unknown-unknown
+      x86_64-apple-darwin
+      x86_64-apple-ios
+      x86_64-apple-ios-macabi
+      x86_64-apple-tvos
+      x86_64-fortanix-unknown-sgx
+      x86_64-fuchsia
+      x86_64-linux-android
+      x86_64-pc-solaris
+      x86_64-pc-windows-gnu
+      x86_64-pc-windows-msvc
+      x86_64-sun-solaris
+      x86_64-unknown-dragonfly
+      x86_64-unknown-freebsd
+      x86_64-unknown-haiku
+      x86_64-unknown-hermit
+      x86_64-unknown-illumos
+      x86_64-unknown-l4re-uclibc
+      x86_64-unknown-linux-gnu
+      x86_64-unknown-linux-gnux32
+      x86_64-unknown-linux-musl
+      x86_64-unknown-netbsd
+      x86_64-unknown-none
+      x86_64-unknown-none-linuxkernel
+      x86_64-unknown-openbsd
+      x86_64-unknown-redox
+      x86_64-unknown-uefi
+      x86_64-uwp-windows-gnu
+      x86_64-uwp-windows-msvc
+      x86_64-wrs-vxworks
+    )
+  end
+end

test/rustler_precompiled/config_test.exs

@@ -3,7 +3,7 @@ defmodule RustlerPrecompiled.ConfigTest do
 
   alias RustlerPrecompiled.Config
 
-  test "new/0 sets `force_build?` to true when pre-release version is used" do
+  test "new/1 sets `force_build?` to true when pre-release version is used" do
     config =
       Config.new(
         otp_app: :rustler_precompiled,
@@ -16,7 +16,7 @@ defmodule RustlerPrecompiled.ConfigTest do
     assert config.force_build?
   end
 
-  test "new/0 sets `force_build?` when configured" do
+  test "new/1 sets `force_build?` when configured" do
     config =
       Config.new(
         otp_app: :rustler_precompiled,
@@ -30,7 +30,7 @@ defmodule RustlerPrecompiled.ConfigTest do
     assert config.force_build?
   end
 
-  test "new/0 requireds `force_build` option when is not a pre-release" do
+  test "new/1 requireds `force_build` option when is not a pre-release" do
     assert_raise KeyError, ~r/key :force_build not found/, fn ->
       Config.new(
         otp_app: :rustler_precompiled,
@@ -41,4 +41,62 @@ defmodule RustlerPrecompiled.ConfigTest do
       )
     end
   end
+
+  test "new/1 validates the given targets" do
+    opts = [
+      otp_app: :rustler_precompiled,
+      module: RustlerPrecompilationExample.Native,
+      base_url:
+        "https://github.com/philss/rustler_precompilation_example/releases/download/v0.2.0",
+      version: "0.2.0-dev"
+    ]
+
+    assert_raise RuntimeError,
+                 "`:targets` is required to be a list of targets supported by Rust",
+                 fn ->
+                   Config.new(opts ++ [targets: "aarch64-unknown-linux-gnu"])
+                 end
+
+    assert_raise RuntimeError,
+                 """
+                 `:targets` contains targets that are not supported by Rust:
+
+                 ["aarch64-unknown-linux-foo"]
+                 """,
+                 fn ->
+                   Config.new(
+                     opts ++
+                       [
+                         targets: [
+                           "aarch64-unknown-linux-gnu",
+                           "aarch64-unknown-linux-gnu_ilp32",
+                           "aarch64-unknown-linux-musl",
+                           "aarch64-unknown-linux-foo"
+                         ]
+                       ]
+                   )
+                 end
+  end
+
+  test "new/1 configures a set of default targets" do
+    config =
+      Config.new(
+        otp_app: :rustler_precompiled,
+        module: RustlerPrecompilationExample.Native,
+        base_url:
+          "https://github.com/philss/rustler_precompilation_example/releases/download/v0.2.0",
+        version: "0.2.0-dev"
+      )
+
+    assert config.targets == [
+             "aarch64-apple-darwin",
+             "x86_64-apple-darwin",
+             "x86_64-unknown-linux-gnu",
+             "x86_64-unknown-linux-musl",
+             "arm-unknown-linux-gnueabihf",
+             "aarch64-unknown-linux-gnu",
+             "x86_64-pc-windows-msvc",
+             "x86_64-pc-windows-gnu"
+           ]
+  end
 end