Add max_retries option #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should make installations more reliable when a network connection is not stable enough. By default it is going to retry downloads three times before giving up.
|
@josevalim would you mind to take a look? 💜 |
josevalim
reviewed
Jul 6, 2023
josevalim
reviewed
Jul 6, 2023
josevalim
reviewed
Jul 6, 2023
josevalim
reviewed
Jul 6, 2023
Co-authored-by: José Valim <jose.valim@gmail.com>
wojtekmach
reviewed
Jul 6, 2023
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
|
@josevalim @wojtekmach thank you, guys! 💜 |
wojtekmach
reviewed
Jul 6, 2023
|
|
||
| defp with_retry(fun, attempts) when attempts in 0..15 do | ||
| task = Task.async(fun) | ||
| first_try = Task.await(task, :infinity) |
There was a problem hiding this comment.
you're doing async/await right away. If you don't use Task for the timeout, is it useful?
There was a problem hiding this comment.
I was being lazy, but yeah, it's not useful 😅
Fixed in d6a323e
There was a problem hiding this comment.
there's one more similar place :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should make installations more reliable when a network connection is not stable enough.
By default it is going to retry downloads three times before giving up.