Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for featured links #117

Closed
wants to merge 5 commits into from
Closed

Conversation

rapzo
Copy link

@rapzo rapzo commented Jan 13, 2020

  • still only placeholders (kittens!!!)
  • need to replace proper image source in src/data/links.yaml
    where featured: true
  • also, cleared some of red warnings (the ones that came across my eyes anyways)

@rapzo rapzo mentioned this pull request Jan 14, 2020
src/data/links.yaml Outdated Show resolved Hide resolved
@philsturgeon
Copy link
Owner

I was actually going to ask if we could figure out how to get these as local files. I started it locally but had to do day job things.

@rapzo
Copy link
Author

rapzo commented Jan 14, 2020

Though so. Gonna write something that downloads it and uses the sharpen plugin accordingly.
Also, do you want the card to have the picture as a cap or overlay (which might turn out nice as well)?

@rapzo
Copy link
Author

rapzo commented Jan 14, 2020

Well, diving a bit more, i recon there's netlify admin (sorry to miss that previously) so images can be uploaded there. I assume links.yaml is generated from there?
Kind of in a crossroad now...

@philsturgeon
Copy link
Owner

The admin is a work in progress which so far doesn’t work.

@rapzo
Copy link
Author

rapzo commented Jan 14, 2020 via email

@rapzo
Copy link
Author

rapzo commented Jan 16, 2020

I guess this is it?
Not very happy with the mess i created. Any tips or is it what was intended?

@rapzo rapzo requested a review from mbifulco January 16, 2020 11:57
@mbifulco
Copy link
Collaborator

Don't be so hard on yourself - images in gatsby can be a bit of a mess. Everything here looks sensible to me. Can you set a featured image for one category so we can test this out?

@rapzo
Copy link
Author

rapzo commented Jan 16, 2020 via email

@philsturgeon
Copy link
Owner

@rapzo netlify cms is up and running now!
image

Sorry for the change whilst you're working. I was imagining we'd just have local files saved by humans and point to them in a file, like categories, but I like your effort to make it awesome.

If there is a way we can just upload images to a "link" then click a featured checkbox, that sounds amazing.

@rapzo
Copy link
Author

rapzo commented Jan 16, 2020 via email

@philsturgeon
Copy link
Owner

Hey I hope things are going ok over there. Sorry things were a bit of a mess before but netlify cms seems to have stabilized. Let me know if I can help with anything :D

@rapzo
Copy link
Author

rapzo commented Jan 26, 2020 via email

@rapzo
Copy link
Author

rapzo commented Jan 27, 2020

Closing this one and will open a new one since this code is not useful while using netlify-cms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants