Set up a hook for useCountry #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will help with the eventual setup of a country switcher
|
Make sure whatever we do does not conflict with #83. @stephensamra are you ok with Mike running with this one? |
|
Thanks @mbifulco, this is definitely a cleaner approach. Will come in handy for #83 👍 @philsturgeon I'm good with this, I'll incorporate it into the country selectory improvements soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work in this PR will help with the eventual setup of a country switcher. I created a shorthand for the
<CountryContext.Consumer>component with a react hook, which is basically an easier-to-read shorthand. Functionally, this is identical to what was there before - but will help with code readability.