Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs category, image and relevant links #138

Merged

Conversation

giovannidisiena
Copy link

Closes #137

@giovannidisiena
Copy link
Author

@philsturgeon I don't have access to the CI - would you be able to let me know why the checks are failing please?

Copy link
Owner

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@philsturgeon philsturgeon merged commit cf12801 into philsturgeon:master Jan 31, 2020
@giovannidisiena giovannidisiena deleted the 137_add_jobs_category branch January 31, 2020 11:00
@HeidiHansen
Copy link

HeidiHansen commented Jan 31, 2020

@giovannidisiena, this could have been failing due to the use of 'uk' instead of 'gb' for country code. https://en.wikipedia.org/wiki/ISO_3166-1#Officially_assigned_code_elements

@giovannidisiena
Copy link
Author

@HeidiHansen good spot, thank you!

@philsturgeon
Copy link
Owner

dont worry i sorted it out. I've made the same mistake many times. Also you had a .jpg vs .jpeg which I've also done many times.

giovannidisiena added a commit to giovannidisiena/awesome-earth that referenced this pull request Jan 31, 2020
@giovannidisiena
Copy link
Author

@philsturgeon ahh, well thank you both!

@philsturgeon
Copy link
Owner

If you have it in you to do another, the #130 could do with similar treatment. If you do it, please look for existing food stuff in our links and move em over too.

@giovannidisiena
Copy link
Author

@philsturgeon if I have some time free up then I will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs category
3 participants