Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

This is a quickfix on DbDeployTask where in rare cases, there's not a…

… newline at the end of last delta.

This creates a statement like the following example:

    -- //UPDATE changelog

So the last deltaset prevents the query to update changelog table to finalise the process.
  • Loading branch information...
commit 1132f85b97286cc143b0d7ab6e938c7d04f72d77 1 parent 473fe20
Michelangelo DragonBe authored
Showing with 2 additions and 0 deletions.
  1. +2 −0  classes/phing/tasks/ext/dbdeploy/DbDeployTask.php
2  classes/phing/tasks/ext/dbdeploy/DbDeployTask.php
View
@@ -269,6 +269,8 @@ protected function generateSql($undo = false)
AND delta_set = \'' . $this->deltaSet . '\';' . "\n";
} else {
$sql .= substr($contents, 0, $split);
+ // Ensuring there's a newline after the final -- //
+ $sql .= PHP_EOL;
$sql .= 'UPDATE ' . DbDeployTask::$TABLE_NAME . '
SET complete_dt = ' . $this->dbmsSyntax->generateTimestamp() . '
WHERE change_number = ' . $fileChangeNumber . '
Please sign in to comment.
Something went wrong with that request. Please try again.