Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP-CS-Fixer #1094

Closed
krukru opened this issue Jul 26, 2019 · 8 comments
Closed

Support PHP-CS-Fixer #1094

krukru opened this issue Jul 26, 2019 · 8 comments

Comments

@krukru
Copy link
Contributor

krukru commented Jul 26, 2019

Is there any interest in supporting PHP-CS-Fixer?
Phing already has great built-in support for tasks like phpstan, php codesniffer, phpmd, phpcpd and various other tools, is it possible to include php-cs-fixer as well?:)

@mrook
Copy link
Member

mrook commented Jul 26, 2019

There's definitely interest. If you're willing to contribute some code, we'd more than welcome it :-)

@peter279k
Copy link

It looks like it already has the PHP_CodeSniffer and it's defined inside require-dev block in composer.json.

Do we need to have another coding style check tool for this repository?

@mrook
Copy link
Member

mrook commented Aug 9, 2019

@peter279k this is about a task to run php-cs-fixer.

@peter279k
Copy link

@mrook, thanks for your quick reply and explanation.

Ok. I think it's fine to add this php-cs-fixer defined inside require-dev block in composer.json if this is about a task.

I think we can also create another task about adding the static code analyze tool in development environment.

Such as phpstan, psalm and etc.

@siad007
Copy link
Member

siad007 commented Nov 9, 2019

Related to #654

@stale
Copy link

stale bot commented May 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 7, 2020
@siad007 siad007 removed the wontfix label May 17, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Oct 22, 2020
@siad007 siad007 self-assigned this Oct 22, 2020
@mrook mrook removed this from the 3.0.0-rc1 milestone Dec 16, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@mrook
Copy link
Member

mrook commented May 16, 2022

I'm going to close this for now - the core contributors don't have time/bandwidth to develop this. If you have some code to contribute, feel free to re-open and we'll see where we can assist.

@mrook mrook closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants