Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace @expectedException* anotation #1191

Merged
merged 3 commits into from Nov 17, 2019
Merged

replace @expectedException* anotation #1191

merged 3 commits into from Nov 17, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Nov 10, 2019 •
edited

As the @expectedException* anotations are deprecated, This PR wants to replace them.

@codecov
Copy link

codecov bot commented Nov 10, 2019 •
edited

Codecov Report

Merging #1191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1191   +/-   ##
=========================================
  Coverage     47.42%   47.42%           
  Complexity     9937     9937           
=========================================
  Files           505      505           
  Lines         24409    24409           
=========================================
  Hits          11576    11576           
  Misses        12833    12833

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a86ba...b211ecd. Read the comment docs.

@mimmi20 mimmi20 changed the title [wip] replace @expectedException* anotation replace @expectedException* anotation Nov 11, 2019
@siad007 siad007 added cleanup code cleanup core labels Nov 16, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Nov 16, 2019
siad007
siad007 approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siad007 siad007 merged commit 6286617 into phingofficial:master Nov 17, 2019
@mimmi20 mimmi20 deleted the remove-phpunit-exception-anotations branch November 17, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siad007 siad007 siad007 approved these changes

Assignees
No one assigned
Labels
cleanup code cleanup core
Milestone
3.0.0-alpha4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mimmi20 @siad007