Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logger] Fixed StatisticsReport #1557

Merged
merged 4 commits into from Mar 21, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 21, 2021

  • Fixed bug in StatisticsReport when using a StatisticsListener in conjunction with a Xml/JsonLogger
  • TimestampedLogger extends now the AnsiColorLogger also.
  • Made use of DefaultClock in DefaultLogger constructor providing timer function for all Loggers

@siad007 siad007 added this to the 3.0.0-RC2 milestone Mar 21, 2021
@siad007 siad007 self-assigned this Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1557 (5cfb84f) into main (135030c) will increase coverage by 0.13%.
The diff coverage is 51.85%.

❗ Current head 5cfb84f differs from pull request most recent head 29d153c. Consider uploading reports for the commit 29d153c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1557      +/-   ##
============================================
+ Coverage     55.83%   55.96%   +0.13%     
- Complexity     6908     6913       +5     
============================================
  Files           356      356              
  Lines         16721    16739      +18     
============================================
+ Hits           9336     9368      +32     
+ Misses         7385     7371      -14     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Filter/ConcatFilter.php 76.36% <ø> (ø) 24.00 <0.00> (ø)
src/Phing/Filter/StripWhitespace.php 86.95% <ø> (ø) 6.00 <0.00> (ø)
src/Phing/Io/DirectoryScanner.php 75.55% <ø> (ø) 99.00 <0.00> (ø)
src/Phing/Io/File.php 83.15% <0.00%> (ø) 91.00 <0.00> (ø)
src/Phing/Io/IniFileTokenReader.php 65.78% <ø> (ø) 17.00 <0.00> (ø)
src/Phing/Listener/AnsiColorLogger.php 14.58% <0.00%> (+14.58%) 17.00 <8.00> (ø)
src/Phing/Listener/JsonLogger.php 0.00% <0.00%> (ø) 13.00 <0.00> (ø)
src/Phing/Listener/ProfileLogger.php 0.00% <0.00%> (ø) 8.00 <0.00> (ø)
src/Phing/Listener/ProgressLogger.php 0.00% <0.00%> (ø) 16.00 <0.00> (ø)
src/Phing/Listener/TargetLogger.php 0.00% <0.00%> (ø) 2.00 <0.00> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135030c...29d153c. Read the comment docs.

@siad007 siad007 merged commit 0ca30dc into phingofficial:main Mar 21, 2021
@siad007 siad007 deleted the LoggerRefactor branch March 21, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant