Declare $searchForThis property

[davejennings]

Due to the deprecation of dynamic properties in PHP 8.2 (https://www.php.net/manual/en/migration82.deprecated.php#migration82.deprecated.core.dynamic-properties) any use of phing v2 results in:

$ vendor/bin/phing -v
Creation of dynamic property Phing::$searchForThis is deprecated

$searchForThis doesn't appear to need to be a class property as I can only see use in Phing::execute() but I've just followed suit with what's on the main branch for version 3.

[williamdes]

I applied this onto 2.17.4 and there was more to fix:

[PHP Error] Return type of ConditionBase::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 85 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of ConditionEnumeration::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 369 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of ConditionEnumeration::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 379 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of ConditionEnumeration::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 387 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of ConditionEnumeration::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 364 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of ConditionEnumeration::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 392 of /usr/share/php/phing/tasks/system/condition/ConditionBase.php]
[PHP Error] Return type of IterableFileSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [line 37 of /usr/share/php/phing/types/IterableFileSet.php]


[PHP Error] Creation of dynamic property TargetHandler::$context is deprecated [line 70 of /usr/share/php/phing/parser/TargetHandler.php]
[PHP Error] Creation of dynamic property ElementHandler::$configurator is deprecated [line 91 of /usr/share/php/phing/parser/ElementHandler.php]
[PHP Error] Creation of dynamic property ElementHandler::$configurator is deprecated [line 91 of /usr/share/php/phing/parser/ElementHandler.php]
[PHP Error] Creation of dynamic property ElementHandler::$configurator is deprecated [line 91 of /usr/share/php/phing/parser/ElementHandler.php]

Here are my patches for Debian (please copy them into this PR):

• https://salsa.debian.org/php-team/pear/phing/-/commit/3be56f80a36372af692efb49a27a528e871d0fd2 (PHP 8.2 patches for dynamic property, IteratorAggregate and Iterator) (⚠️ fixed by: https://salsa.debian.org/php-team/pear/phing/-/commit/87ffe7bbd669c49292d44fc8534ed62009081511)
• https://salsa.debian.org/php-team/pear/phing/-/commit/a95c9c95e2e1af71a50177cd15c9045fe0dc12e4 (this PR's patch)

[mrook]

Hi, I'm reluctant to do (another) patch update of Phing 2.x. Are you able to use the latest release candidate for 3.0?

[williamdes]

Hi, I'm reluctant to do (another) patch update of Phing 2.x. Are you able to use the latest release candidate for 3.0?

since debian freezes the 12th I will not have the time to package 3.x
give I just saved phing right in time or it would have Benn excluded from debian as no update was done since ~5 years
see: https://tracker.debian.org/pkg/phing
I wrote some very light auto test: https://salsa.debian.org/php-team/pear/phing/-/tree/debian/latest/debian/tests
any more complex build.xml example is welcome

if you can include the php 8 fixes and make one more 2.x release that would be awesome, gpg signed would be even more awesome :)

I also edited the package.xml a bit: https://salsa.debian.org/php-team/pear/phing/-/blob/debian/latest/debian/patches/0003-Update-the-package-summary.patch

[williamdes]

⚠️ f466181#diff-74183ecaf5e202bbed461a9a4bb0e2b85baefac71c5e381231c5157762553ce5R39

this is a mistake of mine, you should not put this on classes, only methods

[davejennings]

@williamdes: Apologies, I just took the patches and applied quickly. Cheers for your input and reviewing properly.

[williamdes]

all good, maybe there is more because my build.xml is not that complicated

[mrook]

Hi, closing this PR. I don't have time for another 2.x release, I will endeavor to make a final 3.0 release in the next two months or so.

[davejennings]

Cheers for the update, @mrook. Final release for 3.0 would be great, ta. 👍

[williamdes]

Was this merged somewhere?

[davejennings]

Nothing merged from this pull request with the changes being specific to v2.

v3 had already addressed the original change which I just followed suit with before your feedback noting more problems. I assume those too have been dealt with or otherwise refactored on v3 but it's not something I've checked.

Cheers for your help on this PR. While it didn't get merged, the fork was useful for our purposes while we made time to migrate to v3.