Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes executable bit from... #505

Merged
merged 1 commit into from Jun 2, 2016
Merged

Removes executable bit from... #505

merged 1 commit into from Jun 2, 2016

Conversation

donatj
Copy link
Contributor

@donatj donatj commented Jun 2, 2016

I on occasion run a security sweep on our codebase. One of the things it indicates are things that are executable that probably shouldn't be, eg: non-binaries that don't start with #!

Our vendor/phing directory lit up like a christmas tree.

I wrote a little script that removed the exec bit on everything it suggested.

@donatj
Copy link
Contributor Author

donatj commented Jun 2, 2016

The travis failure was a network timeout, and not the change.

@mrook
Copy link
Member

mrook commented Jun 2, 2016

Thanks!

@mrook mrook merged commit e3bf50d into phingofficial:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants