Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notice "A non well formed numeric value encountered" in PHP 7.1 #620

Merged
merged 1 commit into from Nov 9, 2016
Merged

Conversation

kukulich
Copy link
Contributor

@kukulich kukulich commented Nov 7, 2016

No description provided.

@mrook mrook merged commit 4b7c20d into phingofficial:master Nov 9, 2016
@lastzero
Copy link

lastzero commented Feb 5, 2017

What release will this be in? It's now 3 months later and I still see this error when using the latest ~2.0 via composer.

@mrook
Copy link
Member

mrook commented Feb 5, 2017

It's in 2.16, which was released Dec 22.

@lastzero
Copy link

lastzero commented Feb 7, 2017

For a reason unknown to me, 2.16 requires symfony/yaml in version ^3.1 while your master requires

"symfony/console": "^2.8|^3.0",
"symfony/yaml": "^2.8|^3.1"

That is compatible with Silex 1 projects. Silex 1 does not support Symfony ^3.1 so Phing version 2.15.2 will be installed and not 2.16.0. Silex 2 now supports Symfony 3.x, so Phing 2.16.0 can be installed. Maybe this helps, if somebody has the same issue.

@mrook
Copy link
Member

mrook commented Feb 7, 2017

If required I can roll a 2.16.1 with symfony/yaml set to ^2.8|^3.1.

@lastzero
Copy link

lastzero commented Feb 7, 2017

Sounds good. Why not?

@mrook
Copy link
Member

mrook commented Feb 7, 2017

Because we're working on 3.0 and rolling a release requires time :) Also, there are no other things that need patching in 2.16.

@lastzero
Copy link

lastzero commented Feb 7, 2017

I assume there are other users with the same issue, so it might help. Since I just did the Silex upgrade anyways, I don't need it anymore :)

@XedinUnknown
Copy link

If required I can roll a 2.16.1 with symfony/yaml set to ^2.8|^3.1.

So, will this be done, and if so - when? I really need this to work on PHP 5.4.

@mrook
Copy link
Member

mrook commented May 3, 2018

2.16.1 was released earlier this year: https://github.com/phingofficial/phing/releases/2.16.1

@XedinUnknown
Copy link

2.16.1 requires YAML ^3.1, which requires PHP 5.5.

@mrook
Copy link
Member

mrook commented May 4, 2018

Ah, I wasn't aware of that. I don't think we've ever targeted symfony/yaml 2.8 before, which means we've been incompatible with < 5.5 for a while. Alas, that compatibility was hard to maintain (and Phing 2.x is deprecating anyway).

I'll try to roll a 2.16.2 somewhere next week, with this fixed.

@mrook
Copy link
Member

mrook commented May 4, 2018

Continuing in #919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants