Defer :script uninstall, add :early_script #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge conflicts resolved |
| @@ -71,6 +75,7 @@ def manually_uninstall(uninstall_options) | |||
| end | |||
| end | |||
|
|
|||
| # :quit must come before :kext so the kext will not be in use by the app | |||
There was a problem hiding this comment.
good call on the extra comments to help us understand the order 👌
|
+1 to logic and implementation. Merging |
phinze
added a commit
that referenced
this pull request
Jan 28, 2014
Defer :script uninstall, add :early_script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2254
Previously (#2024), I avoided moving
:scriptto the most sensible place in the order, in part to avoid breaking something.This PR proposes to re-order
:scriptwhere it belongs, and add uninstall key:early_scriptto preserve existing functionality exactly. If any Cask breaks because of re-ordering:script, that Cask can adopt:early_scriptinstead. If no Casks adopt:early_scriptwe can consider it transitional clutter and remove it later on.:early_scriptis added to docs, but deprecated. Code comments are added explaining the reasoning behind uninstall order.