Allow cask instance methods within blocks #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers after_install and after_uninstall. The caveats stanza is treated separately.
|
I agree that ultimately we should have a more explicit DSL for those blocks, and I like the approach you take in #2449, but I also agree that this is a good interim solution. 📥 |
phinze
added a commit
that referenced
this pull request
Jan 18, 2014
Allow cask instance methods within blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2449, a Cask author cannot invoke
destination_pathwithin anafter_installblock. It seems logical that if theafter_installblock is deferred until runtime, it should default to accessing instance methods, as this patch provides.Ultimately, I'd like to add more DSL shortcuts into
after_installas is proposed forcaveatsin #2426.This patch covers
after_installandafter_uninstall. Thecaveatsstanza is treated separately.