Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore non-alpha search chars; accept multi terms #2496

Merged
merged 1 commit into from
Jan 22, 2014
Merged

ignore non-alpha search chars; accept multi terms #2496

merged 1 commit into from
Jan 22, 2014

Conversation

rolandwalker
Copy link
Contributor

Building on the work of @voanhduy1512 in #2471, this patch to brew cask search makes two enhancements.

  • all non-alphanumeric characters are ignored (not just hyphens). This makes the following search work as the user might expect: brew cask search 0xed
  • all terms on the CLI are accepted (instead of respecting only the first argument). This makes the following search work as the user might expect: brew cask search google chrome.

If I get any +1's on this functionality, will add docs and tests to the PR.

@voanhduy1512
Copy link
Contributor

👍 With this cask search will be awesome

@phinze
Copy link
Contributor

phinze commented Jan 20, 2014

+1 for sure. 💾

@nanoxd
Copy link
Contributor

nanoxd commented Jan 20, 2014

💯

@rolandwalker rolandwalker mentioned this pull request Jan 21, 2014
Closed
@rolandwalker
Copy link
Contributor Author

I'm pushing this through without the promised docs/tests to fix #2541 .

rolandwalker added a commit that referenced this pull request Jan 22, 2014
@rolandwalker
Merge pull request #2496 from rolandwalker/search_only_alpha
619e4d7 
ignore non-alpha search chars; accept multi terms
@rolandwalker rolandwalker merged commit 619e4d7 into Homebrew:master Jan 22, 2014
@rolandwalker rolandwalker mentioned this pull request Jan 22, 2014
Merged
rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this pull request Jan 23, 2014
@rolandwalker
search docs/test/fix tapname-search
a5ce3cd 
This is the promised followup to Homebrew#2496
- docs
- test
- bugfix: search string was being tested against fully-qualified
  Cask name including Tap, so "brew cask search phinze" would
  (confusingly) return all Casks.
@rolandwalker rolandwalker deleted the search_only_alpha branch February 8, 2014 21:48
@rolandwalker rolandwalker mentioned this pull request Jun 20, 2014
Merged
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rolandwalker @voanhduy1512 @phinze @nanoxd