Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Aquamacs 3.0a. #2581

Merged
merged 1 commit into from
Jan 28, 2014
Merged

Update: Aquamacs 3.0a. #2581

merged 1 commit into from
Jan 28, 2014

Conversation

goxberry
Copy link
Contributor

Download URL on Aquamacs homepage is a redirect to GitHub. The
redirect URL was determined via curl --write-out redirect_url.

@goxberry
Copy link
Contributor Author

This new version is only for 64-bit Intel Macs, so I've migrated the old version to Homebrew/homebrew-cask-versions#94. I can add caveats to both now, or wait until the PRs land, and then add caveats, depending on what project maintainers would like.

@rolandwalker
Copy link
Contributor

Wow, it took them a long time to get to version 3.

I'm sure there are other 64-bit only Casks. It would be nice to have caveats about that here, and in other cases.

I will add a standard "64-bit only" warning to the caveats DSL. This should have two advantage: 1) standard message 2) it won't fire if the user is already on a 64-bit arch. After the next code release we can try to scan a bunch of the binaries and put that caveat everywhere it belongs.

rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this pull request Jan 24, 2014
@goxberry
Copy link
Contributor Author

@rolandwalker In addition to the architecture caveat, we should probably tell users of Intel 32-bit macs to tap caskroom-versions and download the Aquamacs 2.5 cask I migrated there, similar to the caveats in Cocktail. (At least, that was my plan.)

@rolandwalker
Copy link
Contributor

OK. You just write the best manual caveats you can -- you won't have access to the new arch_only command until the next release anyway. I will try to factor out common needs into the DSL. Referring the user to the versions tap does sound like another good one for the caveats DSL.

Download URL on Aquamacs homepage is a redirect to GitHub. The
redirect URL was determined via `curl --write-out redirect_url`.
Caveats added to redirect users of 32-bit Intel-based Macs to
caskroom/versions/aquamacs25.
@goxberry
Copy link
Contributor Author

Updated with caveats and squashed.

@rolandwalker
Copy link
Contributor

thanks!

@phinze
Copy link
Contributor

phinze commented Jan 28, 2014

Merging this for now, we can use the new arch_only feature in a separate commit.

phinze added a commit that referenced this pull request Jan 28, 2014
@phinze phinze merged commit 99e1ae4 into Homebrew:master Jan 28, 2014
@goxberry goxberry deleted the aquamacs-3.0a branch March 22, 2014 21:29
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants