Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external commands beneath brew cask #2594

Merged
merged 1 commit into from
Jan 28, 2014

Conversation

rolandwalker
Copy link
Contributor

I'm sure some people may think it is silly to have external-commands-under-external-commands. Rationale:

  • We follow Homebrew philosophy where possible.
  • There will always be features like "brew cask open" or maybe "brew cask launch" #2246 that only a small number of users are interested in. Why not let them implement that feature for private use? It also gives us a satisfactory and positive way to answer the issue.
  • Extensibility in the right hands can lead to unexpected new features, even new projects such as homebrew-cask itself.

@phinze
Copy link
Contributor

phinze commented Jan 28, 2014

Wow, great argument on all three points.

Merging with gusto. 💪

phinze added a commit that referenced this pull request Jan 28, 2014
Support external commands beneath `brew cask`
@phinze phinze merged commit a45c118 into Homebrew:master Jan 28, 2014
@rolandwalker rolandwalker deleted the brewcask_external_commands branch February 8, 2014 21:46
@rolandwalker rolandwalker mentioned this pull request Jul 23, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants