realpath hygiene for external commands #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2014
For external commands which do not support the doubledash convention (Homebrew#2613), wrap file arguments in Pathname.new(file).realpath at the very last minute. This provides a guarantee against surprises caused by unusual filenames which might be misinterpreted as flags.
rolandwalker
added a commit
that referenced
this pull request
Feb 4, 2014
realpath hygiene for external commands
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Feb 11, 2014
As in Homebrew#2623. I didn't investigate whether AIR installer supports the doubledash convention.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For external commands which do not support the doubledash convention
(#2613), wrap file arguments in
Pathname.new(file).realpathat thevery last minute. This provides a guarantee against surprises caused
by unusual filenames which might be misinterpreted as flags.
If you follow the current code, the arguments altered by this patch all
ought to be absolute paths already (though not all of them are instances
of Pathname). So, there is no functional change, only a safety rail
against future changes.
This patch covers the external commands
hdiutilandunzip.