BUGFIX: don't try autocleanup inside system dirs #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This safety feature addresses Homebrew#2650 somewhat indirectly. A list of system directories is defined. When the uninstall process encounters a "system directory" it does not touch that directory at all - no chmod on that dir - no search for broken symlinks in that dir - no cleanup of .DS_Store files in that dir Explictly listed files from a pkg receipts are not affected by this change. Individual files will still be removed, even if those files are in a special "system directory"
rolandwalker
added a commit
that referenced
this pull request
Mar 3, 2014
BUGFIX: don't try autocleanup inside system dirs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This safety feature addresses #2650 somewhat indirectly.
A list of system directories is defined. When the uninstall
process encounters a "system directory" it does not touch that
directory at all
chmodon that dir.DS_Storefiles in that dirExplicitly listed files from a
pkgreceipt are not affected bythis change. Individual files will still be removed, even if
those files are in a special "system directory"